Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cpp): add support for linux/arm64 #997

Closed
wants to merge 1 commit into from
Closed

feat(cpp): add support for linux/arm64 #997

wants to merge 1 commit into from

Conversation

joshheyse
Copy link
Contributor

📑 Description

Conditionally ensures clangd installed or uses opts.servers for arm64 system

ℹ Additional Information

I'm not familiar with lua / astronvim coding best practices, I'm sure the control flow could be better and interested in learning how to make it more idiomatic.

@github-actions GitHub Actions
Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title feat(cpp-pack) add support for linux/arm64 feat(cpp): add support for linux/arm64 May 27, 2024
mehalter added a commit that referenced this pull request May 27, 2024
@mehalter @joshheyse
fix(cpp): fix support for linux/arm64 architecture
7de5e2f 
Implements #997

Co-authored-by: Josh Heyse <[email protected]>
@mehalter
Copy link
Member

There were some bugs, so I cleaned this up and committed it manually, thanks!

@mehalter mehalter closed this May 27, 2024
@astronvimbot astronvimbot mentioned this pull request May 27, 2024
Merged
@mehalter mehalter mentioned this pull request May 27, 2024
Closed
@Uzaaft
Copy link
Member

Uzaaft commented May 28, 2024

Heads up. This possibly breaks stuff for Mac users.

@joshheyse
Copy link
Contributor Author

joshheyse commented May 28, 2024 via email

@mehalter
Copy link
Member

should be fixed in latest commit to AstroCommunity

@joshheyse
Copy link
Contributor Author

@Uzaaft thanks for the catch!

@mehalter thanks for the immediate action!

Sorry for submitting such a glaring issue. I even use macOS for a lot of my development in astronvim. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshheyse @mehalter @Uzaaft